Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] #150 웹소켓 개선 #153

Merged
merged 10 commits into from
Dec 9, 2024
Merged

[Feature] #150 웹소켓 개선 #153

merged 10 commits into from
Dec 9, 2024

Conversation

shlee9999
Copy link
Collaborator

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE :

  • 웹 소켓 구독 여러번 하던 문제 수정 (홈페이지에 useSubscribe를 두었기 때문이었음)
  • Token을 받아오기 전에 useSubscribe에서 useSuspenseQuery(useHomeData에서)를 호출해 에러가 나던 문제 해결
    -> useQuery 사용하여 enabled에 토큰 존재 유무를 조건으로 추가
  • 푸시알림 디자인 개선

🖼️ Screenshots

{BD3D4CE5-FCE3-4BB8-9609-5C3D441D1C3F}

@shlee9999 shlee9999 linked an issue Dec 9, 2024 that may be closed by this pull request
[Feature] 웹 소켓 #150
Closed
@shlee9999 shlee9999 enabled auto-merge December 9, 2024 07:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 58
Accessibility 🟢 100
Best Practices 🟠 75
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🔴 3.4 s
Largest Contentful Paint 🔴 4.4 s
Total Blocking Time 🔴 790 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟠 4.0 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 87
Accessibility 🟢 100
Best Practices 🟠 75
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.6 s
Largest Contentful Paint 🟠 3.5 s
Total Blocking Time 🟢 50 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 2.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟢 95
Accessibility 🟢 100
Best Practices 🟠 75
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.1 s
Largest Contentful Paint 🟠 2.5 s
Total Blocking Time 🟢 30 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 2.1 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 74
Accessibility 🟢 100
Best Practices 🟠 75
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🔴 3.2 s
Largest Contentful Paint 🔴 5.4 s
Total Blocking Time 🟢 50 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 3.2 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/profile/:id

Performance Metrics

Category Score
Performance 🟠 72
Accessibility 🟢 100
Best Practices 🟠 75
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🔴 3.3 s
Largest Contentful Paint 🔴 5.7 s
Total Blocking Time 🟢 40 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 3.3 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 merged commit 2582640 into develop Dec 9, 2024
1 check passed
@github-actions github-actions bot deleted the 150-feature/enhance-web-socket branch December 17, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonill wonill wonill approved these changes

@kimjuyoung78 kimjuyoung78 kimjuyoung78 approved these changes

@saseungmin saseungmin Awaiting requested review from saseungmin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 웹 소켓
3 participants
@shlee9999 @kimjuyoung78 @wonill